Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test installation update #2014

Closed

Conversation

learningboiz
Copy link
Contributor

As per issue #2012, I have added a note under the test installation portion of the contribution documents.

I've suggested to wrap quotations around tests ('.[tests]') in case running installations on zsh produces an error.

Kindly let me know if the team would prefer these to be written somewhere else.

@carltongibson
Copy link
Member

Hi @ElijahQuiazon — I merged #2011. Can you rebase after than please.

    * Running the command prompts on Zsh might produce an error
    * Suggestion to use quotations around [tests] to overcome this
@learningboiz
Copy link
Contributor Author

Hey @carltongibson,

Just read up on rebasing to grasp the general idea. Since it's my first time using it, I'm not entirely sure if I did it correctly — so kindly let me know if I should make any changes.

Thank you!

@bigfootjon
Copy link
Collaborator

Should we just modify the inline text? I.e. apply the following change:

-python -m pip install -e .[tests]
+python -m pip install -e '.[tests]'

instead of adding some documentation suffix. Quoting will work with bash just fine so this seems like a better cross-platform solution instead of adding some end-notes for one shell.

What do you think about that @learningboiz?

@learningboiz learningboiz deleted the test-installation-update branch August 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants