Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect pluralization of LocalDjangoCommunity in admin - Issue Solved - #1739 #1754

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

arpan8925
Copy link
Contributor

Added verbose_name_plural = _("Local Django Communities") in the Meta class

arpan8925 and others added 2 commits November 16, 2024 22:32
@bmispelon bmispelon merged commit 18898bc into django:main Nov 21, 2024
4 checks passed
@bmispelon
Copy link
Member

Hi 👋🏻
As Mark pointed out in the previous pull request, the automated tests were failing because the pull request was missing a migration file.

I took the liberty of adding it myself, here's how I did it (from a local version of the site, with a virtualenv activated that had all the necessary requirements):

  • python manage.py makemigrations aggregator -> this created a new file in aggregator/migrations/
  • git add aggregator/migrations/0006_localdjangocommunity_plural.py
  • git commit -m "Added missing migration"
  • git push

Thanks for your contribution! 🌟

@arpan8925
Copy link
Contributor Author

Hi 👋🏻
Thank you for pointing that out and for taking the time to add the missing migration file—I really appreciate your support! 🙏🏻
I'll make sure to include migration files in future contributions to avoid such issues. Thanks again for your guidance and for helping to improve the pull request. 🌟
Best regards,
Arpan

@arpan8925 arpan8925 deleted the arpan8925-issue1739 branch November 23, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants