Add flag to use chapters offset for non audible files tagged using audible api #171
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to tag m4a files I got outside of audible with audible metadata, particularly the chapters markers. Your software has been great at this, however the chapter markers are not accurate due to the audible branding "This is audible" added before the start of each book.
Luckily, audnexus does return this metadata
"brandIntroDurationMs":2043,"brandOutroDurationMs":5061,"chapters":I believe in my testing, only brandIntroDurationMs is useful to offset each chapter's start time.
I've created a feature flag for this
chapter-offset, and tested it briefly and it worked as intended.I'm very new at python and contributing, appreciate if you can check and let me know.