Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Test cases for UserDBConnector #119

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

raizo07
Copy link
Contributor

@raizo07 raizo07 commented Oct 26, 2024

No description provided.

@djeck1432 djeck1432 self-requested a review October 26, 2024 16:52
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run pylint command and fix all issues
pylint $(git ls-files '*.py') --disable=all --enable=C0114,C0115,C0116,C0301

@raizo07
Copy link
Contributor Author

raizo07 commented Oct 26, 2024

@djeck1432 I'm on it now

@djeck1432
Copy link
Owner

@raizo07 test and pylint were failed, please fix that

@djeck1432 djeck1432 linked an issue Oct 26, 2024 that may be closed by this pull request
@raizo07
Copy link
Contributor Author

raizo07 commented Oct 26, 2024

@djeck1432 kindly review

@raizo07 raizo07 requested a review from djeck1432 October 26, 2024 21:26
@djeck1432
Copy link
Owner

Please, @raizo07 fix test cases
https://github.com/djeck1432/spotnet/actions/runs/11535057031/job/32117401302?pr=119

and before creating PR or push your changes, make sure you have run pytest command

@djeck1432
Copy link
Owner

@raizo07 any updates?

@raizo07
Copy link
Contributor Author

raizo07 commented Oct 27, 2024

@raizo07 any updates?

On it

@djeck1432
Copy link
Owner

@raizo07 any results?

@raizo07
Copy link
Contributor Author

raizo07 commented Oct 28, 2024

@djeck1432 Kindly review

@djeck1432
Copy link
Owner

Screenshot 2024-10-28 at 11 03 52 @raizo07 Please, just click approve and run to see result

@raizo07
Copy link
Contributor Author

raizo07 commented Oct 28, 2024

@djeck1432
image

Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit d4b4919 into djeck1432:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Test cases for UserDBConnector
2 participants