Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement restriction to mobile devices #391

Merged
merged 13 commits into from
Dec 18, 2024
Merged

feat: implement restriction to mobile devices #391

merged 13 commits into from
Dec 18, 2024

Conversation

Akshola00
Copy link
Contributor

resolves #388

@whateverfw whateverfw self-requested a review December 17, 2024 07:42
@djeck1432 djeck1432 self-requested a review December 17, 2024 08:02
@Akshola00 Akshola00 marked this pull request as ready for review December 17, 2024 08:03
whateverfw
whateverfw requested changes Dec 17, 2024
View reviewed changes
frontend/src/App.jsx Outdated Show resolved Hide resolved
frontend/src/App.jsx Outdated Show resolved Hide resolved
frontend/src/App.jsx Outdated Show resolved Hide resolved
frontend/src/App.jsx Outdated Show resolved Hide resolved
whateverfw
whateverfw requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove package-lock.json and resolve merge conflict. Apart from that everything is fine

frontend/package-lock.json Outdated Show resolved Hide resolved
@Akshola00
Copy link
Contributor Author

@whateverfw changes made

whateverfw
whateverfw approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akshola00 @djeck1432 lgtm

djeck1432
djeck1432 requested changes Dec 18, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add env variable, like
DISABLE_DESKTOP_ON_MOBILE and if it's True, then we will hide it, if false we will shot it. Just in case we will need to have it under control

@whateverfw
Copy link
Collaborator

@Akshola00 ⏫

@Akshola00
Copy link
Contributor Author

@Akshola00 ⏫
I'm currently working on it
Thank you

@Akshola00
Copy link
Contributor Author

Changes made

djeck1432
djeck1432 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit b8227c8 into djeck1432:main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whateverfw whateverfw whateverfw approved these changes

@djeck1432 djeck1432 djeck1432 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Frontend] Limit user to use mobile version from phone out of mini-app
3 participants
@Akshola00 @whateverfw @djeck1432