Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/refactor wallet connection #438

Closed
wants to merge 5 commits into from
Closed

Feat/refactor wallet connection #438

wants to merge 5 commits into from

Conversation

KeneePatel
Copy link
Contributor

Closes #394

  • refactored get-starknet to starknetkit
  • refactored test cases that ensues
  • removed npm install of get-starknet from Dockerfile
  • The command in docker-compose.back from bash /app/entrypoint.sh to ["/app/entrypoint.sh"] because I guess the bash path is unclear, and it was giving an error

note: let me know if I need to clear yarn.lock from the pr. I wasn't sure about that, but I can remove it if everything else works fine.

@iamnovichek
Copy link
Collaborator

@KeneePatel make sure all pipelines are green

@iamnovichek
Copy link
Collaborator

@KeneePatel make sure all pipelines are green

@iamnovichek
Copy link
Collaborator

@KeneePatel any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Frontend] Change library for connection to wallets
2 participants
@KeneePatel @iamnovichek