updates for frontend wallet connection #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nityam573 make sure all pipelines are green |
|
@iamnovichek all pipelines are green please check |
|
@Nityam573 What is the issue you are assigned to? I cannot find it. |
|
@iamnovichek I wasn't assigned to any but was able to resolve this one |
|
@Nityam573 Did you talk about that with @djeck1432 ? |
iamnovichek
requested changes
Dec 26, 2024
frontend/src/services/wallet.js
Outdated
| const starknet = await connect(); | ||
| if (!starknet.isConnected) { | ||
| const { wallet } = await connect({ | ||
| // connectors: [ |
There was a problem hiding this comment.
Do we need this commented code here?
|
@iamnovichek review please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #394