Fixing bug that meant printing a vector matching expression with matc…

…her labels would incorrectly not include empty parenthesis for group_right/ group_left (#10) Co-authored-by: James Luck <[email protected]>
djluck · Aug 29, 2022 · 2e6cf0e · 2e6cf0e
1 parent 2575ca7
commit 2e6cf0e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/PromQL.Parser/Printer.cs b/src/PromQL.Parser/Printer.cs
@@ -173,7 +173,7 @@ public virtual void Visit(VectorMatching vm)
                 _sb.Append(vm.MatchCardinality.ToPromQl());
             }
 
-            if (vm.Include.Length > 0)
+            if (vm.Include.Length > 0 || vm.MatchCardinality != VectorMatching.DefaultMatchCardinality)
             {
                 if (_sb.Length > 0)
                     _sb.Append(" ");

diff --git a/tests/PromQL.Parser.Tests/PrinterTests.cs b/tests/PromQL.Parser.Tests/PrinterTests.cs
@@ -136,7 +136,7 @@ public void VectorMatching_GroupRight_NoLabels_ToPromQl()
                 false,
                 ImmutableArray<string>.Empty,
                 false
-            )).Should().Be("group_right");
+            )).Should().Be("group_right ()");
         }
 
         [Test]
-Original file line number
+Diff line change
@@ Expand Up / @@ -136,7 +136,7 @@ public void VectorMatching_GroupRight_NoLabels_ToPromQl() @@
                     false,
                     ImmutableArray<string>.Empty,
                     false
-                )).Should().Be("group_right");
+                )).Should().Be("group_right ()");
             }
             [Test]
@@ Expand Down @@