Merge pull request #27 from djoamersfoort/feat/roles-set-intersection

feat: use set intersection for role check in sync
djoamersfoort · Mar 17, 2024 · 6cf24ea · 6cf24ea
2 parents 21c78fa + 877ad03
commit 6cf24ea
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/corvee/src/corvee.py b/corvee/src/corvee.py
@@ -10,7 +10,8 @@
 
 
 class Corvee:
-
+    type_filter = {'member', 'senior', 'strippenkaart'}
+
     @staticmethod
     def is_sync_needed():
         try:
@@ -37,7 +38,8 @@ def update_members(access_token):
 
         members = response.json()
         for member in members:
-            if 'member' not in member['types'] and 'strippenkaart' not in member['types']:
+            type_set = set(member['types'])
+            if not self.type_filter.intersection(type_set):
                 continue
 
             try: