Fix null pointer dereference #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, line 439 was giving me a null pointer dereference when I didn't have my pads hooked up (possibly also when I did? I didn't test that far). This may also be related to doing a drastic update for my base computer. I didn't try to narrow down exactly why. This patch fixes the null pointer dereference; however, I do not know for certain that there isn't something wrong going on here that would require a bail instead of a skip. After the patch my arcade's top buttons seem to function fine, and I haven't tested anything else.
This possibly addresses the same issue as #18 but in a different manner, but my dumb ass didn't find that PR or the other issue regarding it until after I manually hunted down the error and created a patch.