Refine huge enum types #3576
Open
Refine huge enum types #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 64bit int as underlying type of enum is not officially supported by C11 standard. The actual behavior is compiler-dependent. These enums cause portability issue, making us unable to use other compilers. We have some huge enum types that exceed or almost exceed the 32bit boundary. Use #define to handle those until we can switch to C++ or C23 standard. Type: Code Improvement Change-Id: I2cd965c45e469d67ab35fe0a1c0a8401d07689ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 64bit int as the underlying type of enum is not officially supported by the C11 standard. The actual behavior is compiler-dependent. These enums cause portability issues, making us unable to use other compilers.
Some huge enum types exceed or almost exceed the 32-bit boundary.
Use #define to handle those until we switch to C++ or C23 standard.
Type: Code Improvement
Change-Id: I2cd965c45e469d67ab35fe0a1c0a8401d07689ca