Separate dev and docs requirements from setup.py

dkliban · Mar 13, 2017 · d8ace30 · d8ace30
1 parent 2caf79a
commit d8ace30
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 4 deletions.
diff --git a/app/pulp/app/settings.py b/app/pulp/app/settings.py
@@ -12,6 +12,7 @@
 
 import os
 import sys
+from importlib import import_module
 
 import yaml
 
@@ -44,9 +45,7 @@
     'django.contrib.staticfiles',
     # third-party
     'django_filters',
-    'crispy_forms',
     'rest_framework',
-    'django_extensions',
     # pulp platform app
     'pulp.app',
 ]
@@ -64,6 +63,20 @@
     # add it to INSTALLED_APPS. :)
     INSTALLED_APPS.append(plugin)
 
+# Optional apps that help with development, or augment Pulp in some non-critical way
+OPTIONAL_APPS = [
+    'crispy_forms',
+    'django_extensions',
+]
+
+for app in OPTIONAL_APPS:
+    try:
+        import_module(app)
+        INSTALLED_APPS.append(app)
+    except ImportError:
+        # app module not installed
+        pass
+
 MIDDLEWARE_CLASSES = [
     'django.middleware.security.SecurityMiddleware',
     'django.contrib.sessions.middleware.SessionMiddleware',

diff --git a/app/setup.py b/app/setup.py
@@ -4,8 +4,6 @@
     'celery',
     'coreapi',
     'Django>=1.8,<1.9',
-    'django-crispy-forms',
-    'django-extensions',
     'django-filter',
     'djangorestframework',
     'psycopg2',

diff --git a/dev_requirements.txt b/dev_requirements.txt
@@ -0,0 +1,4 @@
+# python packages handy for developers, but not required by pulp
+django-crispy-forms
+django-extensions
+ipython
diff --git a/docs/requirements.txt b/docs/requirements.txt
@@ -0,0 +1,2 @@
+sphinx
+sphinx-rtd-theme