fix!: renamed WithHttpClient -> WithHTTPClient.

BREAKING CHANGES: lets follow Go lang standard naming.
dknight · Mar 13, 2023 · 22279c7 · 22279c7
1 parent a52536c
commit 22279c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/client.go b/client.go
@@ -38,8 +38,8 @@ type optionFunc func(*Client)
 
 func (o optionFunc) apply(c *Client) { o(c) }
 
-// WithHttpClient specifies which http client to use.
-func WithHttpClient(httpClient *http.Client) Option {
+// WithHTTPClient specifies which http client to use.
+func WithHTTPClient(httpClient *http.Client) Option {
 	return optionFunc(func(c *Client) { c.httpClient = httpClient })
 }
 

diff --git a/client_test.go b/client_test.go
@@ -574,11 +574,11 @@ func TestNewClient(t *testing.T) {
 	t.Run("specify http client", func(t *testing.T) {
 		t.Parallel()
 
-		httpClient := new(http.Client) // ???
+		httpClient := &http.Client{}
 		client := NewClient(
 			"https://sid.demo.sk.ee/smart-id-rp/v2/",
 			10000,
-			WithHttpClient(httpClient),
+			WithHTTPClient(httpClient),
 		)
 
 		if client.httpClient != httpClient {