Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #338 - A class Inheriting from an AliasSeq item is seen as an error #343

Merged
merged 1 commit into from Jan 17, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 16, 2019

The official grammar pretended that the indexer of a TypeIdentifierPart (called over there an IdentifierList) is always followed by another dotted part, which was wrong.

DMD already did the right fix in its parser but the specs were wrong and misled me in an older PR (#159).
The change to the official spec is here.

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #343 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   84.28%   84.27%   -0.01%     
==========================================
  Files           7        7              
  Lines        5181     5178       -3     
==========================================
- Hits         4367     4364       -3     
  Misses        814      814
Impacted Files Coverage Δ
src/dparse/parser.d 90.67% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa6282...0cd3bd5. Read the comment docs.

@ghost ghost added the auto-merge-squash label Jan 17, 2019
@dlang-bot dlang-bot merged commit 338a7f6 into dlang-community:master Jan 17, 2019
@ghost ghost deleted the issue-338 branch January 17, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants