Update vectorlayer styling in map-cesium #207
Conversation
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @types/[email protected] |
| fillColor: '#FFFFFF', | ||
| strokeColor: '#0072a3', | ||
| strokeWidth: 2, | ||
| clampToGround: false |
There was a problem hiding this comment.
Maybe we can find a better solution here so that the values are not duplicated in the object.
Here is how this object is used in the other mapping libraries
map-ol:
map-maplibre:
There was a problem hiding this comment.
I found a way to access the style properties in a similar way as in map-maplibre. Therefore, I removed the duplicate entries.
|
Thanks @lucas-angermann for this PR! I'll try to check it out soon. |
| @@ -21,8 +21,8 @@ | |||
| "dependencies": { | |||
| "@dlr-eoc/services-map-state": "12.0.0-alpha.2", | |||
| "@dlr-eoc/services-layers": "12.0.0-alpha.2", | |||
| "@cesium/engine": "^3.0.2", | |||
| "@cesium/widgets": "^3.0.2", | |||
| "@cesium/engine": "^6.1.0", | |||
There was a problem hiding this comment.
Updating libraries in the major version could be considered a breaking change.
@voinSR and @MichaelLangbein I think we discussed this once. But with a lot of libraries in our repo, the versions could get very high very quickly. We have to decide how to deal with that.
For now, it is ok because this library was only available as an alpha version.
There was a problem hiding this comment.
Yes, I wanted to update the versions before we create a new release of the libraries.
| if(l.options && l.options.style){ | ||
| const styleProperties = l.options.style(l.data)[0]; | ||
| if(styleProperties){ | ||
| fillColor = Color.fromCssColorString(styleProperties.fill_.color_) || fillColor; |
There was a problem hiding this comment.
It is not optimal to use private properties from OpenLayers here, but we can change that later.
Maybe we can define some common style properties.
l.options.style{
fillColor?: string;
strokeColor?: string;
strokeWidth?: string;
strokeOpacity?: number;
fillOpacity?: number;
circleRadius?: number;
iconImg?: any;
...
}@voinSR what do you think about it?
There was a problem hiding this comment.
This would be ideal.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Vector layers are only displayed in the Cesium default style.
What is the new behavior?
Vector layers can now be styled with optional input.
Does this PR introduce a breaking change?
Other information
Is it part of one/more packages and which?
@dlr-eoc/map-cesium