Feat maplibre #221
Merged
Feat maplibre #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernals - change before release
… setOpacity in updateMlLayer
boeckMt
commented
Mar 15, 2024
| } as const; | ||
|
|
||
| const getFeaturePropStyle = <T>(prop: keyof typeof defaultStyle) => { | ||
| const style: DataDrivenPropertyValueSpecification<T> = ['coalesce', ['get', prop], defaultStyle[prop]]; |
There was a problem hiding this comment.
@indus maybe you can check if this is the correct expression to get the property from the features, and if there is no such property, use a default from the defaultStyle?
There was a problem hiding this comment.
Just by looking at it seems fine. I have no chance to test this. Did you face any problems with it?
There was a problem hiding this comment.
maybe a function like this...
const coalesce= <T>(key: keyof typeof defaultStyle, default?: any) => {
const style: DataDrivenPropertyValueSpecification<T> = ['coalesce', ['get', key], default || defaultStyle[key]];
//...
}
coalesce('fill');
coalesce('fill', '#f00');
coalesce('fill', defaultStyle.primaryColor);...would be more versatile and descriptive?!
lucas-angermann
approved these changes
Mar 18, 2024
boeckMt
added a commit
that referenced
this pull request
Mar 18, 2024
boeckMt
added a commit
that referenced
this pull request
Jul 5, 2024
* pre version after #221 * feat: prerelease * fix: add layer with the correct beforeId on update PaintProperty * BREAKING CHANGE: remove hasUkisLayerMetadata and move addUkisLayerMetadata and getUkisLayerMetadata * fix: workaround that tried to get beforeId after layer was removed * fix: set layout.visibility in style of VectorLayer * BREAKING CHANGE: change imports from move functions - fe12285 * some fixes of 12.0.1-next.1 * version: create prerelease * feat: add tilejson for open-map-style * BREAKING CHANGE: move type IPopupEvent from @dlr-eoc/map-ol to @dlr-eoc/services-layers * fix: set attribution of tms vector layer * version: create prerelease * version: create prerelease * fix: set subdomains of tms vector layer * BREAKING CHANGE: update maplibre-gl to v^4.1.3 * fix: maplibre-gl changed use of addSourceType * fix: maplibre-gl changed exported types * test: fix tiles url for planet_eoc * docs: install workspaces and prereleases * fix: temporary fix for re-exposing StyleLayer from maplibre * docs: update prereleases * version: create prerelease * version: create prerelease * docs: version for prerelease * version: sync in lock file * feat: new function setUkisLayerMetadata * fix: return type of getUkisLayerMetadata * test: get and set UkisLayerMetadata * feat: update maplibre to 4.5.0 #225 * docs: adjusting testing order * fix: small syntax improvement --------- Co-authored-by: ange_lu <[email protected]>
boeckMt
added a commit
that referenced
this pull request
Jul 8, 2024
* pre version after #221 * feat: prerelease * fix: add layer with the correct beforeId on update PaintProperty * BREAKING CHANGE: remove hasUkisLayerMetadata and move addUkisLayerMetadata and getUkisLayerMetadata * fix: workaround that tried to get beforeId after layer was removed * fix: set layout.visibility in style of VectorLayer * BREAKING CHANGE: change imports from move functions - fe12285 * some fixes of 12.0.1-next.1 * version: create prerelease * feat: add tilejson for open-map-style * BREAKING CHANGE: move type IPopupEvent from @dlr-eoc/map-ol to @dlr-eoc/services-layers * fix: set attribution of tms vector layer * version: create prerelease * version: create prerelease * fix: set subdomains of tms vector layer * BREAKING CHANGE: update maplibre-gl to v^4.1.3 * fix: maplibre-gl changed use of addSourceType * fix: maplibre-gl changed exported types * test: fix tiles url for planet_eoc * docs: install workspaces and prereleases * fix: temporary fix for re-exposing StyleLayer from maplibre * docs: update prereleases * version: create prerelease * version: create prerelease * docs: version for prerelease * version: sync in lock file * feat: new function setUkisLayerMetadata * fix: return type of getUkisLayerMetadata * test: get and set UkisLayerMetadata * feat: update maplibre to 4.5.0 #225 * fix: remove ol from map-maplibre deps where removed at 6255646 * BREAKING CHANGE: update ol from 7.3.0 to 9.2.4 #225 * fix: ol types after update use FeatureLike #225 * fix: demo-maps get wms caps not existing layer * refactor: remove not used imports * fix: do not add layers in AfterViewInit, can cause problems with ol map frame state * fix: custom dtm layer after ol update #225 * refactor: add bbox to layers * refactor: regenerate licenses * docs: add Update ol to changelog #225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
CustomLayer) is not workingWhat is the new behavior?
@boeckMt
Commits for this PR will start after: Merge branch 'main' into feat-maplibre
updateStyleLayerPropertiesUKIS_METADATA.ignoreOpacityandUKIS_METADATA.ignoreVisibilityStyleLayersfromCustomLayerorVectorLayer.options.styleStyleLayersforGeoJsonData (test forMultiPolygonandMultiLineString).GeoJsonData), and use the paint property to get colors from features if they are available.Does this PR introduce a breaking change?
Other information
Is it part of one/more packages and which?
@dlr-eoc/map-maplibredemo-maps