Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test #200

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Add integration test #200

merged 2 commits into from
Nov 22, 2023

Conversation

rikhuijzer
Copy link
Contributor

@rikhuijzer rikhuijzer commented Nov 22, 2023 •
edited
Loading

@rikhuijzer
Copy link
Contributor Author

rikhuijzer commented Nov 22, 2023 •
edited
Loading

The integration tests seem to work. In 9a73ab6, it was still tested against master of MLJXGBoostInterface which restricted the version to an older XGBoost. There, the tests correctly skipped running because of incompatible versions. At the time of 90bd4fb, MLJXGboost loosened the compat again and the tests run and succeed.

@rikhuijzer rikhuijzer marked this pull request as ready for review November 22, 2023 18:39
@ExpandingMan ExpandingMan merged commit 08c38da into dmlc:master Nov 22, 2023
5 of 6 checks passed
@ExpandingMan
Copy link
Collaborator

Great, thanks!

@rikhuijzer rikhuijzer deleted the rh/integration-test branch November 22, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rikhuijzer @ExpandingMan