Fix /proc/<pid>/smaps parsing && Avoid summing Pss_Dirty pages #11675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
amaltaro
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Given that another alternative has been merged: #11676
I would suggest to close this PR out. @todor-ivanov if you agree, please go ahead.
|
thanks @amaltaro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11667
Status
ready
Description
The issue #11667 can be solved in 3 different ways. This is the first out of 3 suggested fixes.
/proc/<pid>/smapsfile to avoid includingPss_Dirtymemory pages in the calculation ofPss, which may wrongly increase the accounting of total PSS memory pages (which already includesPss_Dirty)Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None