Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set site lists and update workqueue elements. #12096

Conversation

todor-ivanov
Copy link
Contributor

Fixes #12038

Status

In development

Description

With the current PR we add the new functionality to call all needed setter methods based on a reqArgs dictionary passed from the upper level caller and try to set all of parameters at once.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

No

@todor-ivanov todor-ivanov changed the title Feature sete whitelist update workqueue elements fix 12038 Feature set whitelist update workqueue elements fix 12038 Sep 16, 2024
@todor-ivanov todor-ivanov changed the title Feature set whitelist update workqueue elements fix 12038 Set site lists and update workqueue elements. Sep 16, 2024
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 2 tests added
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 10 warnings and errors that must be fixed
    • 16 warnings
    • 272 comments to review
  • Pylint py3k check: failed
    • 2 errors and warnings that should be fixed
  • Pycodestyle check: succeeded
    • 37 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15210/artifact/artifacts/PullRequestReport.html

todor-ivanov and others added 3 commits September 17, 2024 13:14
Add proper checks for allowed request properties changes && Stop reducing request_args only to RequestPriority for noStatusTransition actions

Extend allowed arguments including stat_keys and RequestStatus && Call the relevant modifiers from _handleNoStatusUpdate

Fix missing RequestName from request_args on mutipple calls of validate_request_update_args

Add proper log messages for Sitelists changes

Remove redundant validation calls && Update reqdb couch with single action && Move reduceReport to Utils.

Typo

Remove forgotten commented lines of code

Review comments

Source files pylint fixes
Unit tests

Unit tests pylint fixes
@todor-ivanov todor-ivanov force-pushed the feature_SeteWhitelist_UpdateWorkqueueElements_fix-12038 branch from 9ca24ff to 0bb4dc9 Compare September 17, 2024 11:19
@todor-ivanov todor-ivanov added the PR: NEVER MERGE This PR is not meant for merging label Sep 17, 2024
@todor-ivanov
Copy link
Contributor Author

NEVER MERGE
MESSED UP BRANCH HISTORY

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 2 new failures
    • 2 tests added
    • 2 changes in unstable tests
  • Python3 Pylint check: failed
    • 11 warnings and errors that must be fixed
    • 9 warnings
    • 218 comments to review
  • Pylint py3k check: failed
    • 2 errors and warnings that should be fixed
  • Pycodestyle check: succeeded
    • 29 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15217/artifact/artifacts/PullRequestReport.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: NEVER MERGE This PR is not meant for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update workqueue elements upon workflow site list change
2 participants