Remove unused JSON encoding choice keywords

[oljemark]

Fixes #12137

Status

not-tested

Description

Remove this seemingly unused keyword, used to enumerate words to JSON-encode.
Let's test it and see if somehow it still does something.

Is it backward compatible (if not, which system it affects?)

MAYBE

Related PRs

External dependencies / deployment changes

[cmsdmwmbot]

Can one of the admins verify this patch?

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 2 changes in unstable tests
• Python3 Pylint check: failed
  • 1 warnings and errors that must be fixed
  • 5 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15291/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 2 changes in unstable tests
• Python3 Pylint check: failed
  • 1 warnings and errors that must be fixed
  • 5 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15292/artifact/artifacts/PullRequestReport.html

[khurtado]

test this please

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 1 new failures
• Python3 Pylint check: failed
  • 1 warnings and errors that must be fixed
  • 5 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15369/artifact/artifacts/PullRequestReport.html

[oljemark]

Hello, @khurtado . Looking at the Jenkins logs here: https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-WMCorePy3-PR-unittests/3530/SLICE=7,label=cms-dmwm-cc7/testReport/junit/WMCore_t.WorkQueue_t.WorkQueue_t/WorkQueueTest/testProductionMultiQueue/ , am I correct in thinking this shows the unit test was failing since #12151 ? Or was the code affected by this PR and succeeded by chance at least once between these two PRs? Or is this one of the unstable tests that can be ignored?

[khurtado]

test this please

[khurtado]

@oljemark #12151 should not affect this PR. Let's re-run jenkins to see what happens, this may be an unstable test.

[dmwm-bot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 3 changes in unstable tests
• Python3 Pylint check: failed
  • 1 warnings and errors that must be fixed
  • 5 comments to review
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/71/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 tests no longer failing
  • 1 changes in unstable tests
• Python3 Pylint check: failed
  • 1 warnings and errors that must be fixed
  • 5 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15385/artifact/artifacts/PullRequestReport.html

[amaltaro]

@oljemark apologies for the belated follow up of these changes. They are looking good to me and I cannot find any use of this structure across the WMCore repository.

@khurtado thanks for looking into this as well.