fix grammar readme.md #1050
Draft
fix grammar readme.md #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve performance of SVG parsing The previous code used to iterate through a list of XmlEventAttributes for every call to getAttribute. The newer code constructs a Map, and looks up the attribute name directly. This seems to show a 30% overall reduction to svg parsing costs. * Fix lint issues highlighted by github * Fix typo
* version bumps * fix coverage for non-write users
* font-style attribute parser
* Add text-decoration support * add golden Co-authored-by: Dan Field <[email protected]>
…ld#575) * change golden file compares to allow +/- 1 in color components * accept format results (only for files changed here) * explicitly require rawRgba bytes
* updated README
* add a simple scrolling benchmark for the example * fix analyzer errors and remove print statements * pub get Co-authored-by: Dan Field <[email protected]>
* add support for currentColor * refactor to support passing colors down from parent * add another circle to show override works * revert strokeColor change for avd Co-authored-by: Lee Standen <[email protected]>
…d#592) - Use repaint boundaries and layers to make sure that SVGs are more raster cache friendly with current limitations in Flutter - Avoid repatining SVG every time an overlapping animation moves - Release picture memory eagerly
* Fix layer reuse, add regression test * Make golden a little more tolerant
* Fix analysis for CI, update changelog, roll v_g further * Update goldens
* Update README.md * Update README.md * Update README.md
I originally didn't format the debugFillProperties because that seems to be what happens in the main flutter library (presumably for better readability), but here it breaks the presubmits. So here is a quick `dart format`.
…nfield#1000) * Fixed the hashcode in SvgStringLoader and SvgBytesLoader. It was accidently using the svg global object, instead of a local field. This caused caches (such as PaintingBinding.instance.imageCache) to misbehave. * Add a test which ensures the embedded image in a SvgPicture is not incorrectly cached and carried over.
* Fix semver violation for SvgPicture * fix for older versions of flutter?
Object.operator== takes an `Object`, and no Dart runtime passes a `null` value to an `==` implementation. SvgTheme's implementation should not have an expanded parameter type of `dynamic`. See flutter/flutter#117838 for the overarching issue for Flutter. Co-authored-by: Dan Field <[email protected]>
* Use package:http, drop dart:html * Format
* Relax http * update test package too * format;
|
Hi there, The Flutter team is now maintaining this package in the flutter/packages repository at this location. We'd appreciate it if you could direct this PR to that location instead. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.