Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle normalized name value for zone_record resource #207

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Handle normalized name value for zone_record resource #207

merged 6 commits into from
Mar 19, 2024

Conversation

DXTimer
Copy link
Contributor

@DXTimer DXTimer commented Mar 13, 2024 •
edited
Loading

This PR ensure that we correctly handle the cases where the dnsimple_zone_record name attribute has been normalized by the API.

  • Cache search logic updated to use normalized value to avoid false negatives.
  • Fixed a bug where the qualified_name attribute was set to the record name in cases where the name was empty (root). It is now set to the zone name.

Closes #196

@DXTimer DXTimer added the bug label Mar 13, 2024
@DXTimer DXTimer requested a review from AGS4NO March 13, 2024 09:49
@DXTimer DXTimer self-assigned this Mar 13, 2024
@DXTimer DXTimer merged commit 93c190a into main Mar 19, 2024
6 checks passed
@DXTimer DXTimer deleted the fix/normalized-record-name branch March 19, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AGS4NO AGS4NO Awaiting requested review from AGS4NO

Assignees

@DXTimer DXTimer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider error when creating a TXT record for SPF
1 participant
@DXTimer