Fixes when building with buildkit #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that it worked fine with 2.7.1, I think composer/composer@c3efff9#diff-3614f0bf6a66fbe9056036cae6165d9eaa2097f5472e976b5f26e32322bedc2fR302 + composer/composer@c3efff9#diff-96b25cef37257db25ed95d466925aaf0feee2ba65b3a5cb22c07ad9bb36b60b7R224 might be the "smoking gun" -- the prior code for that |
|
JK those are mostly the same, I dunno why it's broken on 2.7.2 and only in BuildKit (clearly related to the |
tianon
reviewed
Mar 12, 2024
| @@ -93,6 +93,11 @@ COPY --from=composer:{{ .composer.version }} /usr/bin/composer /usr/local/bin/ | |||
| ENV DRUPAL_VERSION {{ .version }} | |||
| {{ if has("composer") then ( -}} | |||
|
|
|||
| # https://github.com/moby/buildkit/issues/4503 | |||
There was a problem hiding this comment.
Now that we have a docker-library/drupal number, we should maybe inject it too 👀
Suggested change
| # https://github.com/moby/buildkit/issues/4503 | |
| # https://github.com/docker-library/drupal/pull/259 | |
| # https://github.com/moby/buildkit/issues/4503 |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 13, 2024
Changes: - docker-library/drupal@5f1aafc: Merge pull request docker-library/drupal#259 from infosiftr/buildkit - docker-library/drupal@2c93dfe: Fixes when building with buildkit - docker-library/drupal@d1c8fc7: Update GHA YAML with bashbrew example improvements (esp. concurrency:)
martin-g
pushed a commit
to martin-g/docker-official-images
that referenced
this pull request
Apr 3, 2024
Changes: - docker-library/drupal@5f1aafc: Merge pull request docker-library/drupal#259 from infosiftr/buildkit - docker-library/drupal@2c93dfe: Fixes when building with buildkit - docker-library/drupal@d1c8fc7: Update GHA YAML with bashbrew example improvements (esp. concurrency:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current images fail to build since buildkit doesn't have
/.dockerenvduring build; see composer source for its behavior change based in "being in a container".Abbreviated failure log:
(In fact, there is no
webdirectory at all, see the composer issue below)See also:
/.dockerenvdoes not exist during build moby/buildkit#4503Setting the fix as an
ENVso that anythingFROM drupal:10.*can also benefit from it when building via buildkit.