Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP 8.2 from 11+ #266

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

tianon
Copy link
Member

@tianon tianon commented Aug 7, 2024

Fixes #265

@tianon
Copy link
Member Author

tianon commented Aug 7, 2024

We should probably write a basic smoke test here that spins up the image enough to make sure it starts successfully and we can access the setup wizard. 🤔

@tianon
Copy link
Member Author

tianon commented Aug 7, 2024

Maybe we can somehow invoke the code giving that runtime error in the Dockerfile so we can detect high level issues like this at build time? 🤔

@tianon
Copy link
Member Author

tianon commented Aug 7, 2024

Maybe we can somehow invoke the code giving that runtime error in the Dockerfile so we can detect high level issues like this at build time? 🤔

root@49b5a06fb563:/opt/drupal# composer check-platform-reqs
Checking platform requirements for packages in the vendor dir
composer-plugin-api  2.6.0                                                                                 success                                       
composer-runtime-api 2.2.2                                                                                 success                                       
ext-date             8.2.22                                                                                success                                       
ext-dom              20031129                                                                              success                                       
ext-filter           8.2.22                                                                                success                                       
ext-gd               8.2.22                                                                                success                                       
ext-hash             8.2.22                                                                                success                                       
ext-json             8.2.22                                                                                success                                       
ext-mbstring         *                                                                                     success provided by symfony/polyfill-mbstring 
ext-pcre             8.2.22                                                                                success                                       
ext-pdo              8.2.22                                                                                success                                       
ext-session          8.2.22                                                                                success                                       
ext-simplexml        8.2.22                                                                                success                                       
ext-spl              8.2.22                                                                                success                                       
ext-tokenizer        8.2.22                                                                                success                                       
ext-xml              8.2.22                                                                                success                                       
ext-zlib             8.2.22                                                                                success                                       
php                  8.2.22   drupal/core requires php (>= 8.3.0.0-dev) drupal/core requires php (>=8.3.0) failed                                        
root@49b5a06fb563:/opt/drupal# echo $?
1

👀

@tianon
Copy link
Member Author

tianon commented Aug 7, 2024

I think we should get #267 in first (since it shows this failing) and then I'll rebase this. 👀

@yosifkit yosifkit merged commit 0831413 into docker-library:master Aug 7, 2024
44 checks passed
@yosifkit yosifkit deleted the 11-php8.2 branch August 7, 2024 18:17
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Aug 7, 2024
Changes:

- docker-library/drupal@0831413: Merge pull request docker-library/drupal#266 from infosiftr/11-php8.2
- docker-library/drupal@4c58ce5: Remove PHP 8.2 from 11+
- docker-library/drupal@20bc634: Merge pull request docker-library/drupal#267 from infosiftr/composer-check-platform-reqs
- docker-library/drupal@f097290: Add `composer check-platform-reqs` to composer-using installs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drupal 11 requires PHP 8.3 (remove PHP 8.2 variant)
2 participants