Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip-host-cache deprecation warning #1002

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

rawr51919
Copy link
Contributor

@rawr51919 rawr51919 commented Oct 23, 2023

Fixes #990
Fixes #921
Also fixes hfagerlund/quiz_app#9

8.0/config/conf.d/docker.cnf Outdated Show resolved Hide resolved
Removes the `SET GLOBAL` at the beginning of the edited line as per the review comment suggestion
@rawr51919
Copy link
Contributor Author

The 8.0.34-debian PR CI job seems to keep failing on this PR. Can anyone look into why?

@LaurentGoderre
Copy link
Member

LaurentGoderre commented Oct 26, 2023

It's failing because the apt source only has 8.0.35, not 8.0.34

apt-cache madison mysql-community-client                 
mysql-community-client | 8.0.35-1debian11 | http://repo.mysql.com/apt/debian bullseye/mysql-8.0 amd64 Packages

@LaurentGoderre
Copy link
Member

Could you try rebasing on top of master?

@rawr51919
Copy link
Contributor Author

rawr51919 commented Oct 28, 2023

Could you try rebasing on top of master?

this is already on master, strange
EDIT: yeah some commits got added in between

@rawr51919
Copy link
Contributor Author

there, updated to master

@rawr51919
Copy link
Contributor Author

@LaurentGoderre what do you think? build's fixed, ready when you (and other maintainers) are

@LaurentGoderre LaurentGoderre self-requested a review October 30, 2023 15:14
@LaurentGoderre
Copy link
Member

LaurentGoderre commented Oct 30, 2023

It's good on my end. I will let @yosifkit have a final say.

@yosifkit yosifkit merged commit dc35bed into docker-library:master Nov 8, 2023
6 checks passed
@hfagerlund
Copy link

Thanks 👍

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 8, 2023
Changes:

- docker-library/mysql@dc35bed: Fix skip-host-cache deprecation warning (docker-library/mysql#1002)
@rawr51919 rawr51919 deleted the patch-1 branch November 10, 2023 20:27
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 14, 2023
Changes:

- docker-library/mysql@64f9436: Merge pull request docker-library/mysql#1015 from infosiftr/repo-urls
- docker-library/mysql@0097ab8: Update tools repo handling and update innovation to mysql-shell 8.2.1
- docker-library/mysql@dc35bed: Fix skip-host-cache deprecation warning (docker-library/mysql#1002)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants