Use ruby-3.2 for redmine-5.1 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Dec 18, 2023
versions.sh
Outdated
| declare -A rubyVersions=( | ||
| [5.0]='3.1' |
There was a problem hiding this comment.
Minor whitespace nit:
Suggested change
| [5.0]='3.1' | |
| [5.0]='3.1' |
(Should be tabs to match the rest of the file.)
There was a problem hiding this comment.
@tianon Thank you for your response! ✨ 🙇
I ran following (checks no other changes 👀 ), committed it, edited 7d1d1f1 by git rebase -i and ran force push.
yuya@yoshiyuki|18:56:42|0|12.4% git diff
diff --git a/versions.sh b/versions.sh
index 82b001a..39d9cb2 100755
--- a/versions.sh
+++ b/versions.sh
@@ -19,7 +19,7 @@ declare -A alpineVersions=(
# see https://www.redmine.org/projects/redmine/wiki/redmineinstall
defaultRubyVersion='3.2'
declare -A rubyVersions=(
- [5.0]='3.1'
+ [5.0]='3.1'
)
cd "$(dirname "$(readlink -f "$BASH_SOURCE")")"
yuya@yoshiyuki|18:56:44|0|12.4% git add -u
yuya@yoshiyuki|18:56:49|0|12.4% ./update.sh
5.0: 5.0.7
5.1: 5.1.1
processing 5.0/bookworm ...
processing 5.0/alpine3.18 ...
processing 5.1/bookworm ...
processing 5.1/alpine3.18 ...
yuya@yoshiyuki|18:57:09|0|12.4% git diff | wc -l
0
nishidayuya
force-pushed
the
use_ruby3.2_for_redmine5.1
branch
from
19a7612 to
dd3e3aa
Compare
|
Thank you! |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 19, 2023
Changes: - docker-library/redmine@5b28bca: Use ruby-3.2 for redmine-5.1 (docker-library/redmine#309)
martin-g
pushed a commit
to martin-g/docker-official-images
that referenced
this pull request
Apr 3, 2024
Changes: - docker-library/redmine@5b28bca: Use ruby-3.2 for redmine-5.1 (docker-library/redmine#309)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine 5.1 can use Ruby 3.2 🎉: https://www.redmine.org/projects/redmine/wiki/redmineinstall
This pull-request makes us using redmine-5.1 on ruby-3.2.
7d1d1f158b7f5e .19a7612dd3e3aa ) runs./update.sh.