linter updates and gopls linting #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
linter-updates
branch
from
6b9d5bb to
12af5b3
Compare
tonistiigi
commented
Apr 25, 2024
| @@ -186,7 +186,7 @@ func (b *Builder) LoadNodes(ctx context.Context, opts ...LoadNodesOption) (_ []N | |||
| if pl := di.DriverInfo.DynamicNodes[i].Platforms; len(pl) > 0 { | |||
| diClone.Platforms = pl | |||
| } | |||
| nodes = append(nodes, di) | |||
| nodes = append(nodes, diClone) | |||
There was a problem hiding this comment.
This looks like a behavior change 😬
@AkihiroSuda FYI
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
linter-updates
branch
from
12af5b3 to
d0cc9ed
Compare
AkihiroSuda
approved these changes
Apr 25, 2024
crazy-max
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings similar updates as moby/buildkit#4828 moby/buildkit#4829 to buildx