history: inspect json format #2964
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
history-inspect-json
branch
from
30442f6 to
dc65c53
Compare
|
https://github.com/docker/buildx/compare/master...tonistiigi:buildx:history-inspect-format?expand=1 is my wip for adding format. Main difference is that there is a new struct for history inspection instead of raw HistoryRecord with other (random) values. That struct can be formatted and provides similar output to the default text (that also now comes from printing the struct). I think this is preferred. If lgty you may finish that instead. |
tonistiigi
reviewed
Feb 4, 2025
| workers0: | ||
| for _, w := range workers { | ||
| for _, p := range w.Platforms { | ||
| out.DefaultPlatform = platforms.FormatAll(platforms.Normalize(p)) |
There was a problem hiding this comment.
This is not part of the history record. If needed then this can be set into platform key if one is unset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.