Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set systemd limits #43

Merged
merged 1 commit into from
Aug 29, 2018
Merged

set systemd limits #43

merged 1 commit into from
Aug 29, 2018

Conversation

andrewhsu
Copy link
Contributor

Closes #34

@andrewhsu andrewhsu requested review from crosbymichael and a team August 28, 2018 22:09
@andrewhsu
Copy link
Contributor Author

I've tested these changes out on containerd 1.2.0 beta.1 by manually setting these settings on a RHEL7.5 machine with systemd 219 (the oldest of the systemd versions we support on the distros we support) and stuff still works.

@jose-bigio
Copy link

I don't know why the CI / builds are failing on everything.

@andrewhsu
Copy link
Contributor Author

Alpine is having index problem with that particular index from the 3.7 image. In #44 i've bumped alpine version to get a newer one that does not require an index update to install packages.

Signed-off-by: Andrew Hsu <[email protected]>
Copy link

@jose-bigio jose-bigio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jose-bigio jose-bigio merged commit bd59227 into docker:master Aug 29, 2018
@andrewhsu andrewhsu deleted the lim branch August 29, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants