Skip to content

Commit

Permalink
Run integration tests against multiple moby engines/api versions
Browse files Browse the repository at this point in the history
Signed-off-by: Christopher Petito <[email protected]>
  • Loading branch information
krissetto committed Mar 18, 2024
1 parent 20ef813 commit ac23129
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 3 deletions.
17 changes: 16 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,26 @@ jobs:
strategy:
matrix:
variant: [ "integration-dind", "integration-dind-ssl", "integration-dind-ssh" ]
api-version: [1.44, 1.43, 1.42, 1.24] # 1.24 is the oldest supported version
engine-version: [25.0] # latest
include: # ugly repetition because GHA doesn't support lists in these objects so we need a separate entry for each variant
- engine-version: 23.0 # mirantis lts
api-version: 1.42
variant: "integration-dind"
- engine-version: 23.0 # mirantis lts
api-version: 1.42
variant: "integration-dind-ssl"
- engine-version: 23.0 # mirantis lts
api-version: 1.42
variant: "integration-dind-ssh"

steps:
- uses: actions/checkout@v4
- name: make ${{ matrix.variant }}
- name: ${{ matrix.variant }} - v${{ matrix.engine-version }}/v${{ matrix.api-version }}
run: |
docker logout
rm -rf ~/.docker
make ${{ matrix.variant }}
env:
TEST_ENGINE_VERSION: ${{ matrix.engine-version }}
TEST_API_VERSION: ${{ matrix.api-version }}
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
TEST_API_VERSION ?= 1.43
TEST_ENGINE_VERSION ?= 24.0
TEST_API_VERSION ?= 1.44
TEST_ENGINE_VERSION ?= 25.0

ifeq ($(OS),Windows_NT)
PLATFORM := Windows
Expand Down

0 comments on commit ac23129

Please sign in to comment.