Fix for #2989

For using an SID as parameter - which is better because of potential i18n issue with role name - "isInRole()" expect a "System.Security.Principal.SecurityIdentifier" object instead of a "String". That's because of this error that isHypervAdministrator() always return false and and consequently "Administrator" role is requested. Signed-off-by: Olivier Bourgeat <[email protected]>
docker · Nov 19, 2019 · 6eaf4fa · 6eaf4fa
1 parent b170508
commit 6eaf4fa
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/hyperv/powershell.go b/drivers/hyperv/powershell.go
@@ -85,7 +85,7 @@ func isAdministrator() (bool, error) {
 }
 
 func isHypervAdministrator() bool {
-	stdout, err := cmdOut(`@([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole("S-1-5-32-578")`)
+	stdout, err := cmdOut(`@([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole(([System.Security.Principal.SecurityIdentifier]::new("S-1-5-32-578")))`)
 	if err != nil {
 		log.Debug(err)
 		return false