Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the concept DOI to SearchResult #24

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Conversation

coverbeck
Copy link
Collaborator

@coverbeck coverbeck commented Aug 21, 2024

Description
When working on dockstore/dockstore#5745, I realized I didn't surface the conceptdoi in the SearchResult. Surfacing it there can save as an additional API request.

Review Instructions
Review instructions will be in dockstore/dockstore#5880; it should be reviewed in the context of the whole flow.

Issue
dockstore/dockstore#5745
DOCK-2493

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here.

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@coverbeck coverbeck self-assigned this Aug 21, 2024
<javadocExecutable>${java.home}/bin/javadoc</javadocExecutable>
<junit-version>4.12</junit-version>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't used

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@coverbeck coverbeck merged commit d553e25 into main Aug 23, 2024
2 checks passed
@coverbeck coverbeck deleted the feature/5745/detection branch August 23, 2024 00:07
coverbeck pushed a commit to dockstore/dockstore that referenced this pull request Jan 9, 2025
coverbeck pushed a commit to dockstore/dockstore that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants