-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the concept DOI to SearchResult #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coverbeck
commented
Aug 21, 2024
<javadocExecutable>${java.home}/bin/javadoc</javadocExecutable> | ||
<junit-version>4.12</junit-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't used
coverbeck
commented
Aug 21, 2024
denis-yuen
approved these changes
Aug 22, 2024
coverbeck
pushed a commit
to dockstore/dockstore
that referenced
this pull request
Aug 22, 2024
10 tasks
kathy-t
approved these changes
Aug 22, 2024
coverbeck
pushed a commit
to dockstore/dockstore
that referenced
this pull request
Jan 9, 2025
coverbeck
pushed a commit
to dockstore/dockstore
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When working on dockstore/dockstore#5745, I realized I didn't surface the conceptdoi in the
SearchResult
. Surfacing it there can save as an additional API request.Review Instructions
Review instructions will be in dockstore/dockstore#5880; it should be reviewed in the context of the whole flow.
Issue
dockstore/dockstore#5745
DOCK-2493
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here.
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation