Circle2

[jackpordi]

Move to circle2.

Needs changes in the test process (see circle logs), not sure how you want to do that @martinzlocha .

[martinzlocha]

@jackel119 I think you just have to add the copy part to test as well because it looks like thats run in a separate image:

    - cp sampleconfig.py config.py
    - cp sampledb.sqlite3 db.sqlite3

[jackpordi]

@martinzlocha wait, why are we using a sample config? and are the passwords etc in there actually sensitive?

[martinzlocha]

@jackel119 The config file for prod is stored in S3 and then loaded when deploying. I can't exactly remember why I did it this way instead of storing all of this as environment variables.

[jackpordi]

@martinzlocha it should work now.

Not sure how/if deployment's going to work. I can see that you're just using awscli eb command but where are the configs for that?

• I think "master" branch should be the production one. If you want a safer, "master" without deploy then we can make a "develop" branch.

[martinzlocha]

Ok looks good, will approve and merge once #36 goes in to avoid deploying a version which wouldn't work.

[martinzlocha]

LGTM