Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'not contains' operator to Comparison #365

Open
wants to merge 3 commits into
base: 2.1.x
Choose a base branch
from

Conversation

oscmarb
Copy link

@oscmarb oscmarb commented Feb 21, 2023

Adding 'not contains' operator to Comparison

Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I guess the opposite of CONTAINS can be added to the expressions. Please also add your additions to the docs in docs/en/expressions.rst and docs/en/expression-builder.rst.

@oscmarb
Copy link
Author

oscmarb commented Jun 28, 2023

Added, sorry for the delay.

@SenseException
Copy link
Member

SenseException commented Jul 3, 2023

Looks good to me.

The failing Coding Standards build fail doesn't look related to your additions.

Because your PR introduces a new feature it won't be added to the current 2.1 version. A 2.2 branch doesn't exist so I believe it will be the 3.0 branch, but I'm not familiar with the current releases of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants