feat: allow STI child entities to have non-nullable relationships #10155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
sti
branch
2 times, most recently
from
a6ffb28 to
459649e
Compare
|
Do you mean Currently, child entities cannot have relationships marked as nullable…? |
|
as |
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
Unstale
…On Fri, Jan 10, 2025, 04:08 github-actions[bot] ***@***.***> wrote:
There hasn't been any activity on this pull request in the past 90 days,
so it has been marked as stale and it will be closed automatically if no
further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.
—
Reply to this email directly, view it on GitHub
<#10155 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQAJKSUX57HSYIY6DLIA32J42TNAVCNFSM6AAAAABPYXY65CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBRGY2TGNRZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, child entities cannot have relationships marked as non-nullable because SchemaTool generates the relationship join column as
NOT NULL.It has to be marked as nullable, the same as is done for non-nullable columns that are present only in child entity.