Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for failing to update child-parent relation when the child has been prefetched in QB #9429

Open
wants to merge 1 commit into
base: 2.16.x
Choose a base branch
from

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jan 26, 2022

I have discovered this test case that reproduces bug when there's a child relation indexed

/**
 * @OneToMany(targetEntity=GH7212Child::class, mappedBy="parent", indexBy="id")
 * @var GH7212Child[]|Collection
 */
protected $children;

and then join in qb ->leftJoin('p.children', 'c')

then the relationship is not getting updated. $child->setParent(null) produces no change.

@simPod simPod force-pushed the 7212-index-by-relation-bug branch 2 times, most recently from c569b9a to 4d4cc6b Compare January 26, 2022 18:15
@simPod simPod changed the base branch from 2.11.x to 2.13.x April 30, 2022 10:14
@simPod simPod force-pushed the 7212-index-by-relation-bug branch from 4d4cc6b to 1211686 Compare April 30, 2022 10:14
@simPod simPod force-pushed the 7212-index-by-relation-bug branch from 1211686 to 1ac1bde Compare March 17, 2023 11:33
@simPod simPod changed the base branch from 2.13.x to 2.14.x March 17, 2023 11:33
@simPod simPod changed the base branch from 2.14.x to 2.16.x August 1, 2023 18:49
@simPod simPod force-pushed the 7212-index-by-relation-bug branch from 1ac1bde to c0b149e Compare August 1, 2023 18:49
Copy link
Contributor

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Nov 14, 2024
Copy link
Contributor

This pull request was closed due to inactivity.

@github-actions github-actions bot closed this Nov 23, 2024
@simPod
Copy link
Contributor Author

simPod commented Nov 23, 2024

@greg0ire can you reopen please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants