Remove hierarchy.select param #4540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hierarchy.select param stores a static information about the CA hierarchy (root vs. subordinate) which was set during installation but there is no process to update it in case the CA is converted from root to subordinate or vice versa. Also, the param is incorrectly set to root when cloning a subordinate CA. Because of these issues the param is unreliable, so it has been removed from new and existing instances. The pki-server status CLI has also been updated to no longer show the CA hierarchy. If necessary, the CA hierarchy can be determined by checking the CA signing cert. If it is self-signed that means it is a root CA.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@fmarco76 @ckelleyRH Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hierarchy.selectparam stores a static information about the CA hierarchy (root vs. subordinate) which was set during installation but there is no process to update it in case the CA is converted from root to subordinate or vice versa. Also, the param is incorrectly set to root when cloning a subordinate CA.Because of these issues the param is unreliable, so it has been removed from new and existing instances. The
pki-server statusCLI has also been updated to no longer show the CA hierarchy.If necessary, the CA hierarchy can be determined by checking the CA signing cert. If it is self-signed that means it is a root CA.