Fix servlet name for GetApprovalStatus #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit f91fc5c the GetApprovalStatus was updated to use @WebServlet but the servlet name was not set correctly and conflicted with GenerateKeyPairServlet which was causing a problem for TPS token enrollment with server-side key generation, but for some reason the CI did not fail until recently. Now the servlet name has been fixed so the problem should no longer happen.
ckelleyRH
approved these changes
Aug 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
@ckelleyRH Thanks! No worries, the CI should have caught it, but for some reason it didn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit f91fc5c the
GetApprovalStatuswas updated to use@WebServlet(PR #4479) but the servlet name was not set correctly and conflicted withGenerateKeyPairServletwhich was causing a problem for TPS token enrollment with server-side key generation, but for some reason the CI did not fail until recently.Now the servlet name has been fixed so the problem should no longer happen.