[d3d9] Change correctness factor to 0.5f #4471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been doing a lot of testing of this issue to figure out what is up and down.
The original issue the current code fixed is actually a game bug that also happens with the version of the FF13Fix addon used back then (1.4.6). On Windows with native d3d9 amd drivers this issue can be observed when running the game with a 2560 x 1440 resolution.
This was then later fixed in the addon and so if you download the latest version of FF13Fix it will look correct both with the native driver and dxvk with a 0.5f correctness factor. https://github.com/rebtd7/FF13Fix/releases
Fixing the game bug back then in dxvk sadly introduced issues in other games like #3708, #3818 and #4425.
I have tested on radv, amdvlk open , amd pro, nvk and Nvidia prop that a correctness factor of specifically 0.5f fixes those issues. FFXIV will behave like on Windows and the addon can still be used to fix the 1440p bug.
(amdvlk and amd pro didn't want to work with gamescope when faking 1440p)
Fixes #3708
Fixes #3818
Fixes #4425
Closes #4461