Move crontab to recommended location #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegonzalez
requested changes
May 9, 2019
README.md
Outdated
| Add the following line. It will allow the dokku user to overwrite the old crontab as well as restart the cron service after it has been overwritten. | ||
|
|
||
| ```bash | ||
| dokku ALL=(ALL) NOPASSWD: /bin/cp, /usr/sbin/service cron restart |
There was a problem hiding this comment.
This should just be added to it's own sudoers file during the install phase of the plugin.
jonathan-s
force-pushed
the
master
branch
3 times, most recently
from
86ce198 to
02fc60d
Compare
jonathan-s
commented
May 10, 2019
|
|
||
|
|
||
| echo "%dokku ALL=(ALL) NOPASSWD: /bin/cp, /usr/sbin/service cron restart" > /etc/sudoers.d/dokku-supply-config | ||
| chmod 0440 "/etc/sudoers.d/dokku-supply-config" |
There was a problem hiding this comment.
@josegonzalez I've had a look at the nginx and postgres plugin and it seems like this is what's needed. However, when I try to install the plugin the dokku-supply-config is not created. I'm not sure exactly what I'm missing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issue #6. This PR will move a file
crontabto the recommended location for crontab. The user of the plugin will need to add two extra permissions in sudoers to let the dokku user overwrite the crontab correctly the next time their application is deployed.