Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create persistent storage for themes folder #33

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

babarinde
Copy link
Contributor

Create persistent storage for themes folder

@josegonzalez
Copy link
Member

This breaks the default theme.

@josegonzalez
Copy link
Member

As well, this repository is not meant to be directly deployed, but rather to generate a repository that can be deployed. As such, I definitely am not going to merge the Procfile change.

@babarinde
Copy link
Contributor Author

Completely missed the Procfile, would it be possible to create the procfile after the repository has been cloned ?

@josegonzalez
Copy link
Member

This repo is meant to be run locally, so that copy statement will fail.

As well, there is no need for a Procfile, the app runs just fine without it if you just follow the readme instructions.

@babarinde
Copy link
Contributor Author

My mistake, I was deploying the app from a repo located on the same dokku server (which will not often be the case).
Having said that, the objective was to make sure, when for example, the server is rebooted, the app would still be alive and preserve added plugins, uploads and themes.
When you deploy the app at first as is, the plugins and uploads folders are empty (even though the plugins folder isn't empty in the repo) hence a mount of the themes folder also fails because it is also emptied.
Am not sure if a storage mount after the initial git push will work or if an scp will be an overkill.
On another matter, The app runs fine without a procfile but if you try to do a restart as is, it will throw an error saying Procfile does not exist and restart will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants