Fix url checker. Old code fail if any variables contain the alias or REDIS_URL #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind rebasing your change onto the master branch? |
|
Hi @josegonzalez |
…FOO_REDIS_URL would match and believe its already defined.
grizmio
force-pushed
the
fix/url-checker
branch
from
8db4f8a to
62e132e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix url checker. Old code fail if any variables contains REDIS_URL. So FOO_REDIS_URL would match and believe its already used.
Im new to bash scripting and newer to dokku, but I hope this will helps others like it helped me