VertexLoaderBase: Allow the vertex loader type to be set via config #13305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OatmealDome
force-pushed
the
vertexloader-config
branch
from
228487f to
bffaec9
Compare
JosJuice
approved these changes
Jan 26, 2025
|
@OatmealDome feel free to merge this if you think it's useful. I'm fine with this as I think it'd be nice to have the ability to test things like this without recompiling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to set the vertex loader type without having to recompile Dolphin is useful on some platforms. This also makes it easier to use the native vs. software comparison loader, as Dolphin doesn't need to be rebuilt.
Not sure if this is worth upstreaming, but I figured that I could just PR it and see.