Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputCommon/ExpressionParser: Function argument parsing minor cleanup. #13315

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

InputCommon/ExpressionParser: Function argument parsing minor cleanup. #13315

wants to merge 2 commits into from
+56 −85

Conversation

jordan-woyak
Copy link
Member

@jordan-woyak jordan-woyak commented Jan 29, 2025 •
edited
Loading

Made function argument parsing error mention parenthesis instead of comma.
image

Made FunctionExpression::ValidateArguments look at previously set arguments instead of having to provide them.
Made FunctionExpression::SetArguments no longer call/return ValidateArguments() since it's not obvious that would happen from the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamsyntax dreamsyntax dreamsyntax approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordan-woyak @dreamsyntax