Web: connections and connection configuration page redesign #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuliu-dev
changed the title
liuliu-dev
changed the title
Web: connections page redesign
liuliu-dev
changed the title
tbantle22
approved these changes
Jan 24, 2025
web/renderer/components/pageComponents/ConnectionsPage/NewConnection/index.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+36
to
+39
| <MainLayout className={css.container}> | ||
| <Inner /> | ||
| </MainLayout> | ||
| ); |
There was a problem hiding this comment.
Why does this need MainLayout if there's no welcome message?
There was a problem hiding this comment.
when there's no existing connections, we show welcome message, and new connection form.
the ConfigurationPage already has MainLayout
maybe name showWelcomeMsg boolean noExistingConnection instead?
web/renderer/components/pageComponents/ConnectionsPage/NewConnection/index.module.css
Outdated
Show resolved
Hide resolved
web/renderer/components/pageComponents/ConnectionsPage/NewConnection/context/utils.ts
Outdated
Show resolved
Hide resolved
web/renderer/components/pageComponents/ConnectionsPage/NewConnection/context/utils.ts
Outdated
Show resolved
Hide resolved
web/renderer/components/pageComponents/ConnectionsPage/NewConnection/context/utils.ts
Outdated
Show resolved
Hide resolved
Comment on lines
58
to
66
| const isActive = props.index === activeTabIndex; | ||
| const isCompleted = props.index < activeTabIndex; | ||
| return ( | ||
| <Tab | ||
| index={props.index} | ||
| className={cx(css.tab, { | ||
| [css.activeTab]: isActive, | ||
| [css.isCompleted]: isCompleted, | ||
| })} |
There was a problem hiding this comment.
Might help to disable the future tabs if the current tab isn't fully filled out too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections:
Add connections:
