Migrate dolt diff and dolt show to SQL implementation
#6221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macneale4
requested changes
Jun 23, 2023
macneale4
approved these changes
Jun 27, 2023
- temporarily disable `dolt show` - introduce TableInfo struct to maintain SQL table state - update diffWriter to use non-doltdb primitives - update diff.go to use non-doltdb primitives and load most data from SQL
- got basic commit details SQL going - able to print a rudimentary --no-pretty output for basic case
Update `dolt_log` table function to handle "HEAD" as a ref.
…t the create statement. Also, only write out alter statements when they are non-empty.
Update diff.bats tests to remove foreign key resolution text.
When running the command, we determine if `DoltEnv` is required by checking if `--no-pretty` is set, or the user specified non-commit hashes as the input. These two scenarios result in us logging storage-specific data, for which we require `DoltEnv`.
- pass in the timestamp to the error that reports timestamp parsing issues - fix a failing BATS test
…enoting an non-existent table.
- use dbr.InterpolateForDialect to construct queries - remove commented-out lines - fix function comments - add comments to resolveNonCommitSpec
- rename all show.go `show*` functions to `print*` - moved getTimestampColAsUint64 to utils - if needing to execute in local mode, check the type of Queryist to figure this out
PavelSafronov
force-pushed
the
pavel/dolt-diff-migration
branch
from
1d59d8d to
dfdcbc4
Compare
… `limit` in `dbr.Expr`, which avoids quoting the contents.
…ert the value (which may be a string) to the correct type.
# Conflicts: # integration-tests/bats/sql-local-remote.bats
macneale4
approved these changes
Jun 27, 2023
| cd defaultDB | ||
|
|
||
| export DOLT_CLI_PASSWORD="" |
There was a problem hiding this comment.
We unset the DOLT_CLI_PASSWORD var in this file, so I'd prefer you just set the --password everywhere, OR you can specify no user/pwd (which should work now that my auth changes are in).
There was a problem hiding this comment.
Cool, dropping --user arguments in these tests.
| @@ -384,6 +386,8 @@ EOF | |||
| @test "sql-local-remote: verify dolt show behavior" { | |||
| cd defaultDB | |||
|
|
|||
| export DOLT_CLI_PASSWORD="" | |||
There was a problem hiding this comment.
See previous response :)
…al-remote.bats diff tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates the current
dolt diffimplementation to use only SQL.This is done by offloading most of the diffing logic to
dolt_diffanddolt_schema_difftable functions, and making some of the common code generic, so we don't have to rely on DoltDb objects (which rely on dolt internals).This change also partially migrates
dolt showto SQL.dolt showhas the ability to log some of the storage internals in two cases:--no-prettyflag is specifieddolt showis invoked against non-commit hashesWhen either of the above cases occurs, we use DoltEnv to get these structures and log them. In all other cases, we use SQL to get the list of changes.