Handle null JdbcMappingHint gracefully and improve SQL log formatting #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nakamura-to
commented
Jan 5, 2025
nakamura-to
commented
- Implemented a check to handle null JdbcMappingHint in visitObjectWrapper method to prevent NullPointerExceptions.
- Updated SQL log formatting to pass JdbcMappingHint for more detailed context in parameter evaluation and maintained backward compatibility with existing functionality.
Updated SQL log formatting to pass JdbcMappingHint instead of null, providing more detailed context during parameter evaluation. Deprecated methods in SqlLogFormattingVisitor were overridden for backward compatibility, ensuring seamless integration with existing functionality.
Previously, a null JdbcMappingHint could cause a NullPointerException. This fix introduces a check to ensure a default JdbcType is used if the hint is null, preventing potential runtime errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.