Move to a custom substitutions file format #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The new format is easier to read and write, at the cost of a custom parser. * The extra validation during parsing caught a few cases where we were accidentally replacing text with "undefined", due to typos. In particular, Worm Imago 21.3 and Ward Gleaming 9.11. * We now have separate substitutions files for each book. * We now read the substitutions from disk once per book, and pass the parsed result to the worker, which should be more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new format is easier to read and write, at the cost of a custom parser.
The extra validation during parsing caught a few cases where we were accidentally replacing text with "undefined", due to typos. In particular, Worm Imago 21.3 and Ward Gleaming 9.11.
We now have separate substitutions files for each book.
We now read the substitutions from disk once per book, and pass the parsed result to the worker, which should be more efficient.