Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use binary or, not logical or to combine flags #50

Closed
wants to merge 1 commit into from
Closed

Use binary or, not logical or to combine flags #50

wants to merge 1 commit into from

Conversation

f0k
Copy link
Collaborator

@f0k f0k commented Sep 4, 2019

Two flags in an av_seek_frame call where combined using ||. Specifically, AVSEEK_FLAG_BACKWARD || AVSEEK_FLAG_ANY evaluated to 1 || 4 which gives 1, and is the same as AVSEEK_FLAG_BACKWARD alone. Fixed to use | instead. Clang warned about it.

@f0k f0k requested a review from dominikschnitzer September 4, 2019 15:43
@f0k
Copy link
Collaborator Author

f0k commented Sep 4, 2019

Oh, you included that in #47!

@f0k f0k closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschnitzer dominikschnitzer Awaiting requested review from dominikschnitzer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@f0k