-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix for #785 #786
Hotfix for #785 #786
Conversation
there is no format check in the CI so I don't know why that would cause registration to fail. either way we'll see if this works |
I have absolutely no idea why it can't read this file, so my only guess is that it might be related to
|
maybe it's that the file gets modified during the test due to the format call. but the format test should have failed then so that's a bit weird |
running locally it said julia> format(".") which is incorrect since there was a diff λ ~/.julia/dev/JuliaFormatter: git diff
|
That explains why I didn't catch it. But shouldn't |
yeah this is the only time I've seen it fail |
ok weird now it works julia> format_file("test/sciml_style.jl")
false
julia> format("test/")
false
julia>
julia> format(".")
false
julia> format(".")
true I checkout the diff on each format call except the last format(".") So it seems it works julia> using JuliaFormatter
julia> format(".")
false
julia> ^C
julia> format(".")
true on a new repl session and from the CLI λ ~/.julia/dev/JuliaFormatter: j --project=. -e 'using JuliaFormatter; println(format("."))' |
with -t auto (threads) it seems to work as well |
I don't know why this wasn't failing the tests in #785, but I think this is what's failing JuliaRegistries/General#96136.